Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRO-2166-Frontend Changes #69

Merged
merged 8 commits into from
Mar 4, 2024
Merged

PRO-2166-Frontend Changes #69

merged 8 commits into from
Mar 4, 2024

Conversation

vignesha22
Copy link
Contributor

Description

  • Remove Whitelist fn is added in backend as well as frontend

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@linear Linear
Copy link

linear bot commented Feb 27, 2024

PRO-2166 Arka: Frontend Changes

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 27, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ec21066
Status: ✅  Deploy successful!
Preview URL: https://8ff1993b.arka-3qg.pages.dev
Branch Preview URL: https://pro-2166-frontend-changes.arka-3qg.pages.dev

View logs

IAmKio
IAmKio requested changes Feb 27, 2024
View reviewed changes
backend/src/paymaster/index.ts Outdated Show resolved Hide resolved
backend/src/routes/index.ts Show resolved Hide resolved
frontend/src/components/Dashboard.jsx Show resolved Hide resolved
frontend/src/components/Dashboard.jsx Outdated Show resolved Hide resolved
frontend/src/components/Dashboard.jsx Outdated Show resolved Hide resolved
frontend/src/components/Dashboard.jsx Outdated Show resolved Hide resolved
@vignesha22 vignesha22 requested a review from IAmKio February 28, 2024 08:12
IAmKio
IAmKio requested changes Feb 29, 2024
View reviewed changes
Copy link

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst some things are fixed, the indentation seems a huge issue in this PR, could you please check this?

frontend/src/components/Header.jsx Show resolved Hide resolved
IAmKio
IAmKio requested changes Mar 4, 2024
View reviewed changes
backend/src/paymaster/index.ts Outdated Show resolved Hide resolved
@vignesha22 vignesha22 requested a review from IAmKio March 4, 2024 16:38
@vignesha22 vignesha22 merged commit 45cbd5f into master Mar 4, 2024
4 checks passed
@vignesha22 vignesha22 deleted the PRO-2166-Frontend_Changes branch March 4, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@IAmKio IAmKio IAmKio approved these changes

@0xSulpiride 0xSulpiride Awaiting requested review from 0xSulpiride

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vignesha22 @IAmKio @ch4r10t33r